On Sat, 07 Jul 2007 22:17:22 +0530 Satyam Sharma wrote: > This: > > WARNING: kernel/built-in.o(.text+0x16910): Section mismatch: > reference to .init.text: (between 'kthreadd' and 'init_waitqueue_head') > > comes because kernel/kthread.c:kthreadd() is not __init but calls > kthreadd_setup() which is __init. But this is ok, because kthreadd_setup() > is only ever called at init time, and then kthreadd() proceeds into its > "for (;;)" loop. We could mark kthreadd __init_refok, but kthreadd_setup() > with just one callsite and 4 lines in it (it's been that small since > 10ab825bdef8df51) doesn't need to be a separate function at all -- so let's > just move those four lines at beginning of kthreadd() itself. > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Acked-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > > First discussed in http://lkml.org/lkml/2007/6/26/274, > and I keep getting this with: > ... > > kernel/kthread.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > --- > > diff -ruNp a/kernel/kthread.c b/kernel/kthread.c > --- a/kernel/kthread.c 2007-06-26 06:33:08.000000000 +0530 > +++ b/kernel/kthread.c 2007-06-27 02:57:46.000000000 +0530 > @@ -214,23 +214,15 @@ int kthread_stop(struct task_struct *k) > } > EXPORT_SYMBOL(kthread_stop); > > - > -static __init void kthreadd_setup(void) > +int kthreadd(void *unused) > { > struct task_struct *tsk = current; > > + /* Setup a clean context for our children to inherit. */ > set_task_comm(tsk, "kthreadd"); > - > ignore_signals(tsk); > - > set_user_nice(tsk, -5); > set_cpus_allowed(tsk, CPU_MASK_ALL); > -} > - > -int kthreadd(void *unused) > -{ > - /* Setup a clean context for our children to inherit. */ > - kthreadd_setup(); > > current->flags |= PF_NOFREEZE; > --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
