On Thu, 18 Oct 2018 15:48:46 +0900 Masami Hiramatsu <[email protected]> wrote:
> On Wed, 17 Oct 2018 16:59:51 -0400 > Steven Rostedt <[email protected]> wrote: > > > From: "Steven Rostedt (VMware)" <[email protected]> > > > > Andy had some concerns about using regs_get_kernel_stack_nth() in a new > > function regs_get_kernel_argument() as if there's any error in the stack > > code, it could cause a bad memory access. To be on the safe side, call > > probe_kernel_read() on the stack address to be extra careful in accessing > > the memory. A helper function, regs_get_kernel_stack_nth_addr(), was added > > to just return the stack address (or NULL if not on the stack), that will be > > used to find the address (and could be used by other functions) and read the > > address with kernel_probe_read(). > > > > Link: > > http://lkml.kernel.org/r/calcetrxn9zktb9i1lp3qofcpqzhf34bdkuz5d3n0ucmrr+v...@mail.gmail.com > > Requested-by: Andy Lutomirski <[email protected]> > > Signed-off-by: Steven Rostedt (VMware) <[email protected]> > > Looks good to me. > > Reviewed-by: Masami Hiramatsu <[email protected]> > > Thank you, > Thanks Masami, I plan on posting all the patches later today. They already passed all my tests :-) Well, it hasn't broken anything, as I haven't added tests to test your code yet. -- Steve
