> > On Thu, 18 Oct 2018, Winkler, Tomas wrote: > >> -----Original Message----- > >> From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] > >> Sent: Thursday, October 18, 2018 03:15 > >> To: Winkler, Tomas <tomas.wink...@intel.com> > >> Cc: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>; Jason > >> Gunthorpe <j...@ziepe.ca>; Nayna Jain <na...@linux.vnet.ibm.com>; > >> Usyskin, Alexander <alexander.usys...@intel.com>; Struk, Tadeusz > >> <tadeusz.st...@intel.com>; linux-integr...@vger.kernel.org; > >> linux-security- mod...@vger.kernel.org; linux-kernel@vger.kernel.org; > >> sta...@vger.kernel.org > >> Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow. > >> > >> On Tue, 16 Oct 2018, Tomas Winkler wrote: > >>> First, rename out_no_locality to out_locality for bailing out on > >>> both > >>> tpm_cmd_ready() and tpm_request_locality() failure. > >> > >> This is unnecessary change and technically it is not a rename: the > >> commit message text and the code change do not match. Rename is just > >> a rename (i.e. change a variable name foo to bar). > > > > I'm renaming the label because it doesn't match the code flow anymore, > > I can change the commit message, but you please review the code. > > Tomas > > The flow change is unnecessary and does not really have anything to do with > the bug fix.
What I see in the original code is that when tpm_cmd_ready() fails it's jumps to 'out' label and trying to do tpm_go_idle() but instead it should just undoing the locality, so both cmd_read and go idle had a wrong jump. I see both should be fixed. Earlier version was better than this and would have been fine > when taking account the remark from Jason.
