Hi, On Fri, Oct 19, 2018 at 06:53:10PM +0800, Baolin Wang wrote: > The internal resistance of a battery is not a constant in its life cycle, > this varies over the age of the battery or temperature and so on. But we > just want use one constant battery internal resistance to estimate the > battery capacity. Thus this patch introduces one property to present > the battery factory internal resistance for battery information. > > Signed-off-by: Baolin Wang <[email protected]> > Reviewed-by: Linus Walleij <[email protected]> > ---
Looks good to me.
-- Sebastian
> Changes from v4:
> - None.
>
> Changes from v3:
> - Split binding into one separate patch.
> - Add LinusW reviewed tag.
>
> Changes from v2:
> - Rename the property.
> - Improve the commit message.
>
> Changes from v1:
> - New patch in v2.
> ---
> .../devicetree/bindings/power/supply/battery.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt
> b/Documentation/devicetree/bindings/power/supply/battery.txt
> index f4d3b4a..938d027 100644
> --- a/Documentation/devicetree/bindings/power/supply/battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/battery.txt
> @@ -22,6 +22,7 @@ Optional Properties:
> - charge-term-current-microamp: current for charge termination phase
> - constant-charge-current-max-microamp: maximum constant input current
> - constant-charge-voltage-max-microvolt: maximum constant input voltage
> + - factory-internal-resistance-micro-ohms: battery factory internal
> resistance
>
> Battery properties are named, where possible, for the corresponding
> elements in enum power_supply_property, defined in
> @@ -42,6 +43,7 @@ Example:
> charge-term-current-microamp = <128000>;
> constant-charge-current-max-microamp = <900000>;
> constant-charge-voltage-max-microvolt = <4200000>;
> + factory-internal-resistance-micro-ohms = <250000>;
> };
>
> charger: charger@11 {
> --
> 1.7.9.5
>
signature.asc
Description: PGP signature
