+               [EMAIL PROTECTED] {
+                       #interrupt-cells = <2>;

    Hm, why define that prop for a node with no children?

+                       interrupts = <17 8>;
+                       interrupt-map = <0 0 0 1 700 17 8>;
+                       interrupt-map-mask = <0>;

This map-mask makes no sense either.  And neither does
the map itself.

+
+                       #size-cells = <1>;
+                       #address-cells = <1>;

    Same question here.

The ide node might want children, namely disks or optical
drives or such, but #size-cells should be 0.

+                       reg = <10000000 10 10000200 10>;
+
+                       device_type = "ide";

    I think that already adopted device type is "ata", not "ide".

"ata" is not a hardware thing, "ide" is.  Or so I'm told.
I'd leave out the "device_type" completely though, certainly
if you can't point me at a published device binding :-)


Segher
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to