[RFC][PATCH 02/10] ufs: use fs_umode_to_dtype() helper

[Phillip Potter]

Replace switch statement with common lookup table implementation.

Original patch written by Amir Goldstein.

Signed-off-by: Phillip Potter <p...@philpotter.co.uk>
---
 fs/ufs/util.h | 29 +----------------------------
 1 file changed, 1 insertion(+), 28 deletions(-)

diff --git a/fs/ufs/util.h b/fs/ufs/util.h
index 1fd3011ea623..8c7759860739 100644
--- a/fs/ufs/util.h
+++ b/fs/ufs/util.h
@@ -158,34 +158,7 @@ ufs_set_de_type(struct super_block *sb, struct 
ufs_dir_entry *de, int mode)
        if ((UFS_SB(sb)->s_flags & UFS_DE_MASK) != UFS_DE_44BSD)
                return;
 
-       /*
-        * TODO turn this into a table lookup
-        */
-       switch (mode & S_IFMT) {
-       case S_IFSOCK:
-               de->d_u.d_44.d_type = DT_SOCK;
-               break;
-       case S_IFLNK:
-               de->d_u.d_44.d_type = DT_LNK;
-               break;
-       case S_IFREG:
-               de->d_u.d_44.d_type = DT_REG;
-               break;
-       case S_IFBLK:
-               de->d_u.d_44.d_type = DT_BLK;
-               break;
-       case S_IFDIR:
-               de->d_u.d_44.d_type = DT_DIR;
-               break;
-       case S_IFCHR:
-               de->d_u.d_44.d_type = DT_CHR;
-               break;
-       case S_IFIFO:
-               de->d_u.d_44.d_type = DT_FIFO;
-               break;
-       default:
-               de->d_u.d_44.d_type = DT_UNKNOWN;
-       }
+       de->d_u.d_44.d_type = fs_umode_to_dtype(mode);
 }
 
 static inline u32
-- 
2.17.2