On Thu, 2018-10-25 at 02:23 +0800, kbuild test robot wrote: > Hi Laurence, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linux-sof-driver/master] > [also build test ERROR on v4.19 next-20181019] > [if your patch is applied to the wrong git tree, please drop us a > note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Laurence-Oberman/V3- > init-main-c-Enable-watchdog_thresh-control-from-kernel-line/20181025- > 015902 > base: https://github.com/thesofproject/linux master > config: i386-tinyconfig (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > init/main.c: In function 'is_watchdog_thresh_setup': > > > init/main.c:1037:20: error: 'watchdog_thresh' undeclared (first > > > use in this function); did you mean 'proc_watchdog_thresh'? > > get_option(&str, &watchdog_thresh); > ^~~~~~~~~~~~~~~ > proc_watchdog_thresh > init/main.c:1037:20: note: each undeclared identifier is reported > only once for each function it appears in > > vim +1037 init/main.c > > 1033 > 1034 static int __init > 1035 is_watchdog_thresh_setup(char *str) > 1036 { > > 1037 get_option(&str, &watchdog_thresh); > > 1038 return 1; > 1039 } > 1040 __setup("watchdog_thresh=", is_watchdog_thresh_setup); > 1041 > 1042 > > --- > 0-DAY kernel test infrastructure Open Source > Technology Center > https://lists.01.org/pipermail/kbuild-all Intel > Corporation
Hello Randy So I have tested this with no issues, it built clean multiple times no errors and I was able to set the parameter and I have been using it for days. BOOT_IMAGE=(hd0,msdos1)/vmlinuz-4.18.x86_64 root=/dev/mapper/rhel_segstorage3-root ro crashkernel=512M@64M resume=/dev/mapper/rhel_segstorage3-swap rd.lvm.lv=rhel_segstorage3/root rd.lvm.lv=rhel_segstorage3/swap memmap=128G!385G watchdog_thresh=60 [root@segstorage3 ~]# cd /proc/sys/kernel [root@segstorage3 kernel]# cat watchdog_thresh 60 Do I maybe need the below to avoid the warning extern int watchdog_thresh; Thanks Laurence
