Hi Rob, Thanks a lot for your comments! > -----Original Message----- > From: Rob Herring <r...@kernel.org> > Sent: 2018年10月17日 21:52 > To: Z.q. Hou <zhiqiang....@nxp.com> > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; Leo Li > <leoyang...@nxp.com>; shawn...@kernel.org; mark.rutl...@arm.com; > bhelg...@google.com; Mingkai Hu <mingkai...@nxp.com>; M.h. Lian > <minghuan.l...@nxp.com> > Subject: Re: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible > strings > > On Mon, Oct 08, 2018 at 11:14:25AM +0800, Zhiqiang Hou wrote: > > From: Hou Zhiqiang <zhiqiang....@nxp.com> > > > > The pcie compatible string for LS1043A was lost, so add it. > > PCIe > > The subject could be improved to say exactly what compatible string you are > adding. And the subject should start with "dt-bindings: pci: ..." >
Yes, will correct them in v2. > > > > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > > --- > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > index 66df1e81e0b8..5eb1c202932f 100644 > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > @@ -18,6 +18,7 @@ Required properties: > > "fsl,ls2088a-pcie" > > "fsl,ls1088a-pcie" > > "fsl,ls1046a-pcie" > > + "fsl,ls1043a-pcie" > > "fsl,ls1012a-pcie" > > - reg: base addresses and lengths of the PCIe controller register blocks. > > - interrupts: A list of interrupt outputs of the controller. Must > > contain an > > -- > > 2.17.1 > >
