On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > This satisfies a checkpatch warning
Perhaps run your patches through checkpatch with --strict > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c [] > @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev) > sl->master->slave_count--; > } > > -static ssize_t name_show(struct device *dev, struct device_attribute *attr, > char *buf) > +static ssize_t name_show(struct device *dev, > + struct device_attribute *attr, char *buf) atypical alignment. > [] > @@ -170,7 +173,9 @@ static void w1_netlink_queue_status(struct w1_cb_block > *block, > block->msg->len = 0; > block->msg->status = (u8)-error; > if (req_cmd) { > - struct w1_netlink_cmd *cmd = (struct w1_netlink_cmd > *)block->msg->data; > + struct w1_netlink_cmd *cmd = > + (struct w1_netlink_cmd *) block->msg->data; unnecessary space after cast