On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
> thanks for the patch.
>
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdun...@infradead.org>
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> <mtd/onenand.h>, and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops'
>> declared inside parameter list will not be visible outside of this
>> definition or declaration
>> struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera
>> driver")
>
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
>
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?
Oops, thanks, I'll fix that and send a v2 with your Ack.
> In any case:
> Acked-by: Jacopo Mondi <jac...@jmondi.org>
>
> Thanks
> j
>
>>
>> Reported-by: Geert Uytterhoeven <ge...@linux-m68k.org>
>> Suggested-by: Miquel Raynal <miquel.ray...@bootlin.com>
>> Signed-off-by: Randy Dunlap <rdun...@infradead.org>
>> Reviewed-by: Miquel Raynal <miquel.ray...@bootlin.com>
>> Cc: Yoshinori Sato <ys...@users.sourceforge.jp>
>> Cc: Rich Felker <dal...@libc.org>
>> Cc: Jacopo Mondi <jacopo+rene...@jmondi.org>
>> Cc: Magnus Damm <magnus.d...@gmail.com>
>> Cc: linux-...@lists.infradead.org
>> Cc: linux...@vger.kernel.org
>> ---
>> arch/sh/boards/mach-kfr2r09/setup.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>> #include <linux/memblock.h>
>> #include <linux/mfd/tmio.h>
>> #include <linux/mmc/host.h>
>> -#include <linux/mtd/onenand.h>
>> #include <linux/mtd/physmap.h>
>> #include <linux/platform_data/lv5207lp.h>
>> #include <linux/platform_device.h>
>>
>>
--
~Randy
