On Tue, Oct 30, 2018 at 08:42:47AM +0000, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.d...@nxp.com>
> 
> The flexcan1 is pin conflict with fec. So we add a new dts file with
> flexcan1 enabled with fec disabled for user to use.
> 
> Signed-off-by: Dong Aisheng <aisheng.d...@nxp.com>
> Signed-off-by: Joakim Zhang <qiangqing.zh...@nxp.com>

We do not want to maintain a pile of DTS files for a single development
board with pin sharing among different devices.

Shawn

> ---
>  .../boot/dts/imx6dl-sabreauto-flexcan1.dts    | 14 ++++++
>  .../arm/boot/dts/imx6q-sabreauto-flexcan1.dts | 14 ++++++
>  arch/arm/boot/dts/imx6qdl-sabreauto.dtsi      | 47 +++++++++++++++++++
>  3 files changed, 75 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-sabreauto-flexcan1.dts
> 
> diff --git a/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts 
> b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts
> new file mode 100644
> index 000000000000..4ebcc283f549
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts
> @@ -0,0 +1,14 @@
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Copyright (C) 2013 Freescale Semiconductor, Inc.
> +
> +#include "imx6dl-sabreauto.dts"
> +
> +&can1{
> +     status = "okay";
> +};
> +
> +&fec {
> +     /* pin conflict with flexcan1 */
> +     status = "disabled";
> +};
> diff --git a/arch/arm/boot/dts/imx6q-sabreauto-flexcan1.dts 
> b/arch/arm/boot/dts/imx6q-sabreauto-flexcan1.dts
> new file mode 100644
> index 000000000000..e7e684656f09
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-sabreauto-flexcan1.dts
> @@ -0,0 +1,14 @@
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Copyright (C) 2013 Freescale Semiconductor, Inc.
> +
> +#include "imx6q-sabreauto.dts"
> +
> +&can1{
> +     status = "okay";
> +};
> +
> +&fec {
> +     /* pin conflict with flexcan1 */
> +     status = "disabled";
> +};
> diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi 
> b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> index a10f0ad0bfb1..c1111b972b46 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> @@ -101,6 +101,25 @@
>               enable-active-high;
>       };
>  
> +     reg_can_en: regulator-can-en {
> +             compatible = "regulator-fixed";
> +             regulator-name = "can-en";
> +             regulator-min-microvolt = <3300000>;
> +             regulator-max-microvolt = <3300000>;
> +             gpio = <&max7310_b 6 GPIO_ACTIVE_HIGH>;
> +             enable-active-high;
> +     };
> +
> +     reg_can_stby: regulator-can-stby {
> +             compatible = "regulator-fixed";
> +             regulator-name = "can-stby";
> +             regulator-min-microvolt = <3300000>;
> +             regulator-max-microvolt = <3300000>;
> +             gpio = <&max7310_b 5 GPIO_ACTIVE_HIGH>;
> +             enable-active-high;
> +             vin-supply = <&reg_can_en>;
> +     };
> +
>       sound-cs42888 {
>               compatible = "fsl,imx6-sabreauto-cs42888",
>                       "fsl,imx-audio-cs42888";
> @@ -279,6 +298,20 @@
>       status = "okay";
>  };
>  
> +&can1 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&pinctrl_flexcan1>;
> +     xceiver-supply = <&reg_can_stby>;
> +     status = "disabled"; /* pin conflict with fec */
> +};
> +
> +&can2 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&pinctrl_flexcan2>;
> +     xceiver-supply = <&reg_can_stby>;
> +     status = "okay";
> +};
> +
>  &gpmi {
>       pinctrl-names = "default";
>       pinctrl-0 = <&pinctrl_gpmi_nand>;
> @@ -494,6 +527,20 @@
>                       >;
>               };
>  
> +             pinctrl_flexcan1: flexcan1grp {
> +                     fsl,pins = <
> +                             MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX        0x17059
> +                             MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX        0x17059
> +                     >;
> +             };
> +
> +             pinctrl_flexcan2: flexcan2grp {
> +                     fsl,pins = <
> +                             MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX        0x17059
> +                             MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX        0x17059
> +                     >;
> +             };
> +
>               pinctrl_gpio_keys: gpiokeysgrp {
>                       fsl,pins = <
>                               MX6QDL_PAD_SD2_CMD__GPIO1_IO11          0x1b0b0
> -- 
> 2.17.1
> 

Reply via email to