Hi Anson, On 05/11/2018 02:10, Anson Huang wrote: > kfree should be called to free resource in error path > before return. > > Signed-off-by: Anson Huang <[email protected]> > --- > drivers/clocksource/timer-imx-gpt.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/timer-imx-gpt.c > b/drivers/clocksource/timer-imx-gpt.c > index a3d6ccb..0f78b30 100644 > --- a/drivers/clocksource/timer-imx-gpt.c > +++ b/drivers/clocksource/timer-imx-gpt.c > @@ -477,12 +477,16 @@ static int __init mxc_timer_init_dt(struct device_node > *np, enum imx_gpt_type t > return -ENOMEM; > > imxtm->base = of_iomap(np, 0); > - if (!imxtm->base) > + if (!imxtm->base) { > + kfree(imxtm); > return -ENXIO; > + } > > imxtm->irq = irq_of_parse_and_map(np, 0); > - if (imxtm->irq <= 0) > + if (imxtm->irq <= 0) { > + kfree(imxtm); > return -EINVAL; > + } > > imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");
Please convert to timer-of API. Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
