On 10/7/18, 2:03 PM, "Linus Walleij" <linus.wall...@linaro.org> wrote: > > On Wed, Oct 3, 2018 at 11:54 PM Tao Ren <tao...@fb.com> wrote: > >> TIMER_INTR_MASK register (Base Address of Timer + 0x38) is not designed >> for masking interrupts on ast2500 chips, and it's not even listed in >> ast2400 datasheet, so it's not safe to access TIMER_INTR_MASK on aspeed >> chips. >> >> Similarly, TIMER_INTR_STATE register (Base Address of Timer + 0x34) is >> not interrupt status register on ast2400 and ast2500 chips. Although >> there is no side effect to reset the register in fttmr010_common_init(), >> it's just misleading to do so. >> >> Besides, "count_down" is renamed to "is_aspeed" in "fttmr010" structure, >> and more comments are added so the code is more readble. >> >> Signed-off-by: Tao Ren <tao...@fb.com> >> --- >> Changes in v2: >> - "count_down" is renamed to "is_aspeed" in "fttmr010" structure. >> - more comments are added to make the code more readable. > > Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Hi Daniel / Thomas, Any further comments on the patch? Or is there anything needed from my side? Thanks, Tao Ren