On 2018/11/09 18:56, Michal Hocko wrote: > Does this following look better?
Yes. >> Also, why not to add BUG_ON(gfp_mask & __GFP_NOFAIL); here? > > Because we do not want to blow up the kernel just because of a stupid > usage of the allocator. Can you think of an example where it would > actually make any sense? > > I would argue that such a theoretical abuse would blow up on an > unchecked NULL ptr access. Isn't that enough? We after all can't avoid blowing up the kernel even if we don't add BUG_ON(). Stopping with BUG_ON() is saner than NULL pointer dereference messages.
