On Thu, Nov 15, 2018 at 01:12:53AM -0600, Bjorn Helgaas wrote: > > and I kinda see the point of maybe not having your ssh username in the > > URL. Not that it is a big deal for us, k.org users though. > > Sorry, I don't understand the problem. I have this in my .gitconfig: > > [url "ssh://g...@gitolite.kernel.org"] > insteadOf = https://git.kernel.org > insteadOf = http://git.kernel.org > insteadOf = git://git.kernel.org > > because I thought that was the recommended way (see the end of > https://korg.wiki.kernel.org/userdoc/gitolite). But that also makes my > request-pull: > > $ git request-pull origin/master > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > pci-v4.20-fixes-1 > > generate the ssh URL above. If I remove the insteadOf stuff from > .gitconfig, request-pull produces this instead: > > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > tags/pci-v4.20-fixes-1 > > I'm happy to do either; just tell me which :)
You didn't really do anything wrong. In *general* I prefer to see public URLs if they are sent to public lists, so if you're cc'ing something to LKML, I would generally expect the pull request to have a public URL like https://git.kernel.org/ instead of a private ssh:// URL that is only accessible to people with a kernel.org account. That's basically all there is to it. It doesn't *really* matter, since Linus is the one who will be merging the actual pull request, and he certainly has access to internal ssh:// URLs. However, in case someone else was interested in reviewing the pull request, it would be more friendly to have a public URL for them. Best, -K
