From: Masahiro Yamada Sent: November 16, 2018 at 7:37:46 AM GMT > To: Nadav Amit <[email protected]> > Cc: Ingo Molnar <[email protected]>, Michal Marek <[email protected]>, > Thomas Gleixner <[email protected]>, Borislav Petkov <[email protected]>, H. > Peter Anvin <[email protected]>, X86 ML <[email protected]>, Linux Kbuild mailing > list <[email protected]>, Linux Kernel Mailing List > <[email protected]> > Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S > > > On Thu, Nov 15, 2018 at 1:01 PM Nadav Amit <[email protected]> wrote: >> Changes in macros.S should trigger the recompilation of all C files, as >> the macros might need to affect their compilation. >> >> Acked-by: Ingo Molnar <[email protected]> >> Signed-off-by: Nadav Amit <[email protected]> >> --- > > When we talked about this last time, > we agreed to not do this > because a single line change in asm headers > would cause global rebuilding. > > Did you change your mind?
I was wrong (and you were right? I don’t quite remember). Anyhow, another patch I work on made me realize how wrong I was. If required, we can extract the macros from some of the header files into separate header files to prevent unnecessary rebuilds. Thanks, Nadav
