reviewed-by: Minghuan Lian <[email protected]>

> -----Original Message-----
> From: Z.q. Hou
> Sent: Tuesday, November 20, 2018 5:26 PM
> To: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Leo Li
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Cc: Mingkai Hu <[email protected]>; M.h. Lian
> <[email protected]>; Xiaowei Bao <[email protected]>; Z.q. Hou
> <[email protected]>
> Subject: [PATCHv2 03/25] PCI: mobiveil: correct the returned error number
> 
> From: Hou Zhiqiang <[email protected]>
> 
> This patch corrected the returned error number by convention, and removed
> a unnecessary error check.
> 
> Signed-off-by: Hou Zhiqiang <[email protected]>
> ---
> V2:
>  - no change
> 
>  drivers/pci/controller/pcie-mobiveil.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-mobiveil.c
> b/drivers/pci/controller/pcie-mobiveil.c
> index b87471f08a40..563210e731d3 100644
> --- a/drivers/pci/controller/pcie-mobiveil.c
> +++ b/drivers/pci/controller/pcie-mobiveil.c
> @@ -819,7 +819,7 @@ static int mobiveil_pcie_init_irq_domain(struct
> mobiveil_pcie *pcie)
> 
>       if (!pcie->intx_domain) {
>               dev_err(dev, "Failed to get a INTx IRQ domain\n");
> -             return -ENODEV;
> +             return -ENOMEM;
>       }
> 
>       raw_spin_lock_init(&pcie->intx_mask_lock);
> @@ -845,11 +845,9 @@ static int mobiveil_pcie_probe(struct
> platform_device *pdev)
>       /* allocate the PCIe port */
>       bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie));
>       if (!bridge)
> -             return -ENODEV;
> +             return -ENOMEM;
> 
>       pcie = pci_host_bridge_priv(bridge);
> -     if (!pcie)
> -             return -ENOMEM;
> 
>       pcie->pdev = pdev;
> 
> @@ -866,7 +864,7 @@ static int mobiveil_pcie_probe(struct platform_device
> *pdev)
>                                                   &pcie->resources, &iobase);
>       if (ret) {
>               dev_err(dev, "Getting bridge resources failed\n");
> -             return -ENOMEM;
> +             return ret;
>       }
> 
>       /*
> --
> 2.17.1

Reply via email to