On Mon, Nov 19, 2018 at 02:18:55PM +0000, Quentin Perret wrote:
> +static long
> +compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> +{
> + long util, max_util, sum_util, energy = 0;
> + int cpu;
> +
> + for (; pd; pd = pd->next) {
> + max_util = sum_util = 0;
> + /*
> + * The capacity state of CPUs of the current rd can be driven by
> + * CPUs of another rd if they belong to the same performance
> + * domain. So, account for the utilization of these CPUs too
> + * by masking pd with cpu_online_mask instead of the rd span.
> + *
> + * If an entire performance domain is outside of the current rd,
> + * it will not appear in its pd list and will not be accounted
> + * by compute_energy().
> + */
> + for_each_cpu_and(cpu, perf_domain_span(pd), cpu_online_mask) {
Should that not be cpu_active_mask ?
> + util = cpu_util_next(cpu, p, dst_cpu);
> + util = schedutil_energy_util(cpu, util);
> + max_util = max(util, max_util);
> + sum_util += util;
> + }
> +
> + energy += em_pd_energy(pd->em_pd, max_util, sum_util);
> + }
> +
> + return energy;
> +}
