Hi Peter/Thomas, On Tue, Oct 30, 2018 at 12:25 PM Pavankumar Kondeti <pkond...@codeaurora.org> wrote: > > commit 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout") > tried to fix the problem introduced by a previous commit efb40f588b43 > ("sched/tracing: Fix trace_sched_switch task-state printing"). However > the prev_state output in sched_switch is still broken. > > task_state_index() uses fls() which considers the LSB as 1. Left > shifting 1 by this value gives an incorrect mapping to the task state. > Fix this by decrementing the value returned by __get_task_state() > before shifting. > > Fixes: 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout") > Signed-off-by: Pavankumar Kondeti <pkond...@codeaurora.org> > --- > include/trace/events/sched.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-)
Can you please review this patch? -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project