>-----Original Message-----
>From: Mark Brown <broo...@kernel.org>
>Sent: Tuesday, November 27, 2018 3:51 AM
>To: Ryan Lee <ryans....@maximintegrated.com>
>Cc: Liam Girdwood <lgirdw...@gmail.com>; Jaroslav Kysela
><pe...@perex.cz>; Takashi Iwai <ti...@suse.com>; Grant Grundler
><grund...@chromium.org>; Kuninori Morimoto
><kuninori.morimoto...@renesas.com>; Benson Leung
><ble...@chromium.org>; alsa-de...@alsa-project.org; linux-
>ker...@vger.kernel.org
>Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp
>reset
>
>On Mon, Nov 26, 2018 at 06:46:05PM +0000, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans....@maximintegrated.com>
>> ---
>
>This really needs a changelog to explain what is going on here, and we need
>some more documentation in the code.  It is *extremely* unusual to have to
>poll for reset like this, and if the failure mode is I/O errors that's going 
>to be
>pretty painful.
OK. I agree that this is very unusual. I wanted to make this code change very 
conservative and this caused unusual overhead.
Let me fix this.

Reply via email to