On Fri, 13 Jul 2007, Andrew Morton wrote: > On Fri, 13 Jul 2007 10:52:10 +0200 (CEST) Geert Uytterhoeven <[EMAIL > PROTECTED]> wrote: > > > > > Summaries: > > > > [1] fbdev: extract fb_show_logo_line() > > > > [2] fbdev: Add fb_append_extra_logo() > > > > > > This one does give additional code and data to all fbdev users while only > > > being useful to cell machines. Should we fix that? > > > > I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other > > users). Would that be OK? > > umm, your call. If that makes sense, sure.
I just don't like putting platform-specific checks in common code. Perhaps I better add CONFIG_FB_LOGO_EXTRA and make it depend on CONFIG_PPC_CELL? With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: [EMAIL PROTECTED] Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
