According to documentation in include/asm-generic/syscall.h, if error argument of syscall_set_return_value() is nonzero, it is a negated errno.
This change fixes syscall_set_return_value() implementation on microblaze to match its own syscall_get_error(), the documentation, and other architectures where error argument of syscall_set_return_value() is non-positive. Fixes: d5b37092aae1e ("microblaze: Implement include/asm/syscall.h.") Cc: sta...@vger.kernel.org # v2.6.32+ Signed-off-by: Dmitry V. Levin <l...@altlinux.org> --- arch/microblaze/include/asm/syscall.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/microblaze/include/asm/syscall.h b/arch/microblaze/include/asm/syscall.h index 220decd605a4..c2489a591d6b 100644 --- a/arch/microblaze/include/asm/syscall.h +++ b/arch/microblaze/include/asm/syscall.h @@ -36,10 +36,7 @@ static inline void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs, int error, long val) { - if (error) - regs->r3 = -error; - else - regs->r3 = val; + regs->r3 = error ?: val; } static inline microblaze_reg_t microblaze_get_syscall_arg(struct pt_regs *regs, -- ldv