* Peter Zijlstra <pet...@infradead.org> wrote:
> On Mon, Dec 03, 2018 at 11:22:00AM +0100, Ingo Molnar wrote:
> > Go over the tools/ files that are maintained in Arnaldo's tree and
> > fix common typos: half of them were in comments, the other half
> > in JSON files.
> >
> > ( Care should be taken not to re-import these typos in the future,
> > if the JSON files get updated by the vendor without fixing the typos. )
>
> > .../perf/pmu-events/arch/x86/broadwell/cache.json | 4 +--
> > .../pmu-events/arch/x86/broadwell/pipeline.json | 2 +-
> > .../pmu-events/arch/x86/broadwellde/cache.json | 4 +--
> > .../pmu-events/arch/x86/broadwellde/pipeline.json | 2 +-
> > .../perf/pmu-events/arch/x86/broadwellx/cache.json | 4 +--
> > .../pmu-events/arch/x86/broadwellx/pipeline.json | 2 +-
> > tools/perf/pmu-events/arch/x86/jaketown/cache.json | 4 +--
> > .../pmu-events/arch/x86/jaketown/pipeline.json | 2 +-
> > .../pmu-events/arch/x86/knightslanding/cache.json | 30
> > +++++++++++-----------
> > .../pmu-events/arch/x86/sandybridge/cache.json | 4 +--
> > .../pmu-events/arch/x86/sandybridge/pipeline.json | 2 +-
> > .../pmu-events/arch/x86/skylakex/uncore-other.json | 12 ++++-----
>
> Yeah, so I think those are generated from somewhere, fixing them here
> isn't going to nessecarily help much.
It's in our source code, the output is visible to our users, so such
typos should be fixed.
But yes, I agree that the fixes should also be applied at the Intel
source of the JSON definitions.
Thanks,
Ingo
