Miguel Ojeda <miguel.ojeda.sando...@gmail.com> writes: > On Wed, Dec 5, 2018 at 6:58 PM Måns Rullgård <m...@mansr.com> wrote: >> >> Suppose the command "\e[Lx0y0;" is written to the device. The >> charlcd_write_char() function adds one character at a time to the escape >> sequence buffer. > > Ah, yes, that is much more clear. Indeed, parse_xy() expects the > entire command; the strchr() should still be there. > > By the way, if we are going to move to a direct check, I would also do > so in the generator command too if possible, to be consistent (in > another patch, possibly).
I'd consider that separately. You're the maintainer, so it's up to you. >> BTW, the parsing of this command has been broken since 3.2-rc1 due to >> commit 129957069e6a. > > Thanks for checking! Are you able to test this? Yes, that's how I noticed it was broken. -- Måns Rullgård
