On Sun, Jul 15, 2007 at 12:36:51PM +0200, Michael Buesch wrote: > On Sunday 15 July 2007 11:27:09 Bryan Wu wrote: > > +#if defined(CONFIG_BFIN_MAC_USE_L1) > > +# define bfin_mac_alloc(dma_handle, size) l1_data_sram_zalloc(size) > > +# define bfin_mac_free(dma_handle, ptr) l1_data_sram_free(ptr) > > +#else > > +# define bfin_mac_alloc(dma_handle, size) \ > > + dma_alloc_coherent(NULL, size, dma_handle, GFP_NORMAL) > > What is GFP_NORMAL? It's not defined in latest linus' tree. > I think you should use GFP_KERNEL, if you can sleep, or GFP_ATOMIC, > if you can't.
Actually this whole thing looks fishy. There should be a struct device for the dma allocation, through a platform_device. And the CONFIG_BFIN_MAC_USE_L1 should go away, the l1 sram should have a dma provider so this can be handled through the dma api. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
