When you revamp everything I guess it would make the locks easier to read to just put them into a .S file? They're out of line anyways.
In general they look ok. > > static inline void __raw_spin_unlock(raw_spinlock_t *lock) > { > - asm volatile("movl $1,%0" :"=m" (lock->slock) :: "memory"); > + __asm__ __volatile__( Minor nit: please don't use these underlined keywords. They just look ugly and asm volatile works as well. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/