Linus Torvalds wrote: > > On Thu, 19 Jul 2007, Bartlomiej Zolnierkiewicz wrote: >> Thanks for finding and fixing this. >> >> The latest patch (with additional cleanups) also looks good and should be >> safe enough (unchanged behavior for all non-pc requests) to merge it now. >> >> Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > Ok, Jens - mind signing off on the patch you sent out, and writing an > explanatory message? Feel free to just crib from my explanation of my > original patch, or whatever. > > And it would be beautiful if people who saw the bad behaviour before > reverting the ide.c changes were to go back to that broken state, and try > the patch, and just verify that it acts like it should (ie you should see > just a few error messages, and it shouldn't cause the IDE layer to go > ballistic any more).
Ok, I tested a5fcaa210626a79465321e344c91a6a7dc3881fa , with the Jeans' patch with clean-up (Message-ID: <[EMAIL PROTECTED]>). I don't see the error loop. but only 4 errors (2 for each hd, at hddtemp start) Jul 19 08:22:19 catee kernel: hda: selected mode 0x45 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hda: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 14657019, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4780, biotail c21a4780, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hdc: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 34711027, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4740, biotail c21a4740, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hdc: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 7387152, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4900, biotail c21a4900, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hda: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 7387152, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4900, biotail c21a4900, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:27 catee kernel: ttyS1: LSR safety check engaged! The last git tree give me no errors. patch in Message-ID: <[EMAIL PROTECTED]> Tested-By: Giacomo Catenazzi <[EMAIL PROTECTED]> ciao cate - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/