Whoops, didn't notice that Andrew and LKML fell off Cc. Sorry. Håvard
On Thu, 19 Jul 2007 11:01:22 +0200 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > On Thu, 19 Jul 2007 08:53:44 +0200 > Hans-Christian Egtvedt <[EMAIL PROTECTED]> wrote: > > > >> +EXPORT_SYMBOL(ssc_request); > > >> > > > > > > All exports need justification, please. An additional paragraph in the > > > changelog would suit. > > > > > How are exports justified? Can they be removed since the user have to > > include <linux/atmel-ssc.h> anyway? > > No, we do need these since modules are going to link to them. > > The idea is that other drivers call these functions to obtain a > reference to one of the SSC instances in the system. Such drivers > typically implement some sort of serial frame-based protocol, e.g. i2s, > by programming the SSC controller directly. This driver is out of the > way after a protocol driver has successfully requested an instance. > > So the protocol drivers need some kind of resource management in order > to not step on each others' toes, and that's the reason for the export > of ssc_request() and ssc_free(). > > I'm not sure if anyone would have been very mad at me for sneaking this > in through the avr32 tree, but I'd really like to know what others, in > particular the AT91 people and David, think of this kind of thing > before it ends up in mainline. > > Feel free to add > > Acked-by: Haavard Skinnemoen <[EMAIL PROTECTED]> > > to both patches (the driver and the fix) though. It's been through a > few rounds of internal review. > > Håvard > _______________________________________________ > Kernel mailing list > [EMAIL PROTECTED] > http://duppen.flaskehals.net/cgi-bin/mailman/listinfo/kernel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/