On Tue, Jul 24, 2007 at 07:39:38AM +0100, Simon Arlott wrote:
> The following commit appears to break some of my udev rules (I don't
> have the time to finish the bisect right now, but there's only four
> changes showing in "git bisect visualize" - this one is tagged
> bisect/bad, and the other three are docs/docs/unrelated).
>
> Neither of these symlinks get created by udev on kernels marked bad
> (see bisect log below):
>
> ACTION=="add", \
> KERNEL=="event*", \
> SUBSYSTEM=="input", \
> SYSFS{description}=="i8042 KBD port", \
> NAME="input/%k", \
> SYMLINK="input/i8042-kbd", \
> MODE="0640", \
> GROUP="event"
>
> ACTION=="add", \
> KERNEL=="event*", \
> SUBSYSTEM=="input", \
> SYSFS{manufacturer}=="Logitech", \
> SYSFS{product}=="USB-PS/2 Optical Mouse", \
> NAME="input/%k", \
> SYMLINK="input/logitech-mouse", \
> MODE="0640", \
> GROUP="event"
>
> Author: Cornelia Huck <[EMAIL PROTECTED]> 2007-07-18 09:43:47
> Committer: Greg Kroah-Hartman <[EMAIL PROTECTED]> 2007-07-18 23:49:50
> Parent: be3884943674f8ee7656b1d8b71c087ec900c836 (HOWTO: Add the
> knwon_regression URI to the documentation)
>
> Driver core: check return code of sysfs_create_link()
>
> Check for return value of sysfs_create_link() in device_add() and
> device_rename(). Add helper functions device_add_class_symlinks() and
> device_remove_class_symlinks() to make the code easier to read.
>
> [EMAIL PROTECTED]: fix unused var warnings]
>
> Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]>
> Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Ugh, I thought this was all fixed up properly :(
Cornelia, can you work to figure this out?
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
