On Wed, Dec 05, 2018 at 01:50:44PM -0600, Rob Herring wrote:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
> 
> For instances using of_node_cmp, this has the side effect of now using
> case sensitive comparisons. This should not matter for any FDT based
> system which this is.
> 
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Jingoo Han <jingooh...@gmail.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
> Cc: dri-de...@lists.freedesktop.org
> Cc: linux-fb...@vger.kernel.org
> Signed-off-by: Rob Herring <r...@kernel.org>

Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>

[this is FAO Lee J. rather than recommending you take it via you tree]

> ---
>  drivers/video/backlight/88pm860x_bl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/88pm860x_bl.c 
> b/drivers/video/backlight/88pm860x_bl.c
> index 6d8dc2c77520..51e0c4be08df 100644
> --- a/drivers/video/backlight/88pm860x_bl.c
> +++ b/drivers/video/backlight/88pm860x_bl.c
> @@ -174,7 +174,7 @@ static int pm860x_backlight_dt_init(struct 
> platform_device *pdev,
>               return -ENODEV;
>       }
>       for_each_child_of_node(nproot, np) {
> -             if (!of_node_cmp(np->name, name)) {
> +             if (of_node_name_eq(np, name)) {
>                       of_property_read_u32(np, "marvell,88pm860x-iset",
>                                            &iset);
>                       data->iset = PM8606_WLED_CURRENT(iset);
> -- 
> 2.19.1
> 

Reply via email to