3.16.62-rc1 review patch. If anyone has any objections, please let me know.
------------------ From: Lior David <qca_li...@qca.qualcomm.com> commit b5a8ffcae4103a9d823ea3aa3a761f65779fbe2a upstream. Add a length check in wmi_set_ie to detect unsigned integer overflow. Signed-off-by: Lior David <qca_li...@qca.qualcomm.com> Signed-off-by: Maya Erez <qca_me...@qca.qualcomm.com> Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com> [bwh: Backported to 3.16: return directly rather than via "out" label] Signed-off-by: Ben Hutchings <b...@decadent.org.uk> --- --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -958,7 +958,12 @@ int wmi_set_ie(struct wil6210_priv *wil, { int rc; u16 len = sizeof(struct wmi_set_appie_cmd) + ie_len; - struct wmi_set_appie_cmd *cmd = kzalloc(len, GFP_KERNEL); + struct wmi_set_appie_cmd *cmd; + + if (len < ie_len) + return -EINVAL; + + cmd = kzalloc(len, GFP_KERNEL); if (!cmd) return -ENOMEM;