On Sat, 08 Dec 2018, Oskari Lemmela wrote:

> Parts of the AXP803 are compatible with their counterparts on the AXP813.
> These include the GPIO, ADC, AC and battery power supplies.
> 
> Signed-off-by: Oskari Lemmela <[email protected]>
> Reviewed-by: Chen-Yu Tsai <[email protected]>
> Tested-by: Vasily Khoruzhick <[email protected]>
> Signed-off-by: Chen-Yu Tsai <[email protected]>

I'm happy to fix this, but ...

Can you explain these tags for me please?

Specifically the last one.

Why does Chen-Yu Tsai have an SoB there?

> ---
>  drivers/mfd/axp20x.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 8037b4e01ed6..f8e0fa97bb31 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -726,6 +726,20 @@ static const struct mfd_cell axp803_cells[] = {
>               .name           = "axp221-pek",
>               .num_resources  = ARRAY_SIZE(axp803_pek_resources),
>               .resources      = axp803_pek_resources,
> +     }, {
> +             .name           = "axp20x-gpio",
> +             .of_compatible  = "x-powers,axp813-gpio",
> +     }, {
> +             .name           = "axp813-adc",
> +             .of_compatible  = "x-powers,axp813-adc",
> +     }, {
> +             .name           = "axp20x-battery-power-supply",
> +             .of_compatible  = "x-powers,axp813-battery-power-supply",
> +     }, {
> +             .name           = "axp20x-ac-power-supply",
> +             .of_compatible  = "x-powers,axp813-ac-power-supply",
> +             .num_resources  = ARRAY_SIZE(axp20x_ac_power_supply_resources),
> +             .resources      = axp20x_ac_power_supply_resources,
>       },
>       {       .name           = "axp20x-regulator" },
>  };

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Reply via email to