On Tue, Jul 24, 2007 at 04:08:11PM -0700, David Brownell wrote: > On Tuesday 24 July 2007, Russell King wrote: > > On Tue, Jul 24, 2007 at 02:29:05PM -0700, David Brownell wrote: > > > On at least ARM (and I'm told MIPS too) dma_free_coherent() has a newish > > > call context requirement: unlike its dma_alloc_coherent() sibling, it > > > may not be called with IRQs disabled. (This was new behavior on ARM as > > > of late 2006, caused by ARM SMP updates.) > > > > I think you got the year wrong: > > > > 5edf71ae (Russell King 2005-11-25 15:52:51 +0000 364) > > WARN_ON(irqs_disabled()); > > > > which is due to this commit: > > > > [ARM] Do not call flush_tlb_kernel_range() with IRQs disabled. > > This little "to do" list item has been sitting in my mailbox way > too long then. Certainly since it was fair to say "last year"! ;)
Are you intentionally not reading what I said? > > Signed-off-by: Russell King <[EMAIL PROTECTED]> > > Thanks... That was part of the commit I quoted, not an endorsement of your patch, though I think it does deserve an: Acked-by: Russell King <[EMAIL PROTECTED]> -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
