[Re: [PATCH 17/18] mfd: wm8350-core: drop unused MODULE_ tags from non-modular code] On 10/12/2018 (Mon 06:38) Lee Jones wrote:
> On Fri, 07 Dec 2018, Paul Gortmaker wrote: [...] > > Cc: Linus Walleij <linus.wall...@linaro.org> > > Cc: Lee Jones <lee.jo...@linaro.org> > > Cc: patc...@opensource.cirrus.com > > Acked-by: Linus Walleij <linus.wall...@linaro.org> > > Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> > > When you submit this patch again (collecting more Acks or > what-have-you), please re-order your tags chronologically. Thanks. Will do. Here is v3 --> v3a ; adding the orphan function removal rightfully requested by Charles. With an ack or two on this, I will send a v4 with all Acks and in order after SOB, and hopefully we are done here, and can avoid a v5 of this series. Thanks for your patience everyone. Paul. -- >From 4711117ed697823f61974bdea5678e6ce225cf9b Mon Sep 17 00:00:00 2001 From: Paul Gortmaker <paul.gortma...@windriver.com> Date: Wed, 6 Jul 2016 16:46:39 -0400 Subject: [PATCH] mfd: wm8350-core: drop unused module infrastructure from non-modular code The Kconfig currently controlling compilation of this code is: drivers/mfd/Kconfig:config MFD_WM8350 drivers/mfd/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only. We delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. We replace module.h with init.h and export.h ; the latter since the file does export some symbols. Previous demodularizaion work has made wm8350_device_exit() no longer used, so it is also removed from the 8350 core code. Cc: Linus Walleij <linus.wall...@linaro.org> Cc: Charles Keepax <ckee...@opensource.cirrus.com> Cc: Lee Jones <lee.jo...@linaro.org> Cc: patc...@opensource.cirrus.com Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c index 8a07c5634aee..9e1070f26b11 100644 --- a/drivers/mfd/wm8350-core.c +++ b/drivers/mfd/wm8350-core.c @@ -13,7 +13,8 @@ */ #include <linux/kernel.h> -#include <linux/module.h> +#include <linux/init.h> +#include <linux/export.h> #include <linux/slab.h> #include <linux/bug.h> #include <linux/device.h> @@ -442,30 +443,3 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq, return ret; } EXPORT_SYMBOL_GPL(wm8350_device_init); - -void wm8350_device_exit(struct wm8350 *wm8350) -{ - int i; - - for (i = 0; i < ARRAY_SIZE(wm8350->pmic.led); i++) - platform_device_unregister(wm8350->pmic.led[i].pdev); - - for (i = 0; i < ARRAY_SIZE(wm8350->pmic.pdev); i++) - platform_device_unregister(wm8350->pmic.pdev[i]); - - platform_device_unregister(wm8350->wdt.pdev); - platform_device_unregister(wm8350->rtc.pdev); - platform_device_unregister(wm8350->power.pdev); - platform_device_unregister(wm8350->hwmon.pdev); - platform_device_unregister(wm8350->gpio.pdev); - platform_device_unregister(wm8350->codec.pdev); - - if (wm8350->irq_base) - free_irq(wm8350->irq_base + WM8350_IRQ_AUXADC_DATARDY, wm8350); - - wm8350_irq_exit(wm8350); -} -EXPORT_SYMBOL_GPL(wm8350_device_exit); - -MODULE_DESCRIPTION("WM8350 AudioPlus PMIC core driver"); -MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/wm8350/core.h b/include/linux/mfd/wm8350/core.h index 509481d9cf19..202d9bde2c7c 100644 --- a/include/linux/mfd/wm8350/core.h +++ b/include/linux/mfd/wm8350/core.h @@ -643,7 +643,6 @@ struct wm8350_platform_data { */ int wm8350_device_init(struct wm8350 *wm8350, int irq, struct wm8350_platform_data *pdata); -void wm8350_device_exit(struct wm8350 *wm8350); /* * WM8350 device IO -- 2.7.4