* Kuninori Morimoto <kuninori.morimoto...@renesas.com> [181211 03:31]:
> 
> Hi Tony
> 
> > Here are two fixes that allow me to have multiple endpoints defined in
> > the dts file for audio-graph-card. To do that, we need to fix up few
> > issues as the graph binding Documentation/devicetree/bindings/graph.txt
> > allows multiple endpoints per port. This allows configuring TDM codecs
> > for I2S for example.
> > 
> > Kuninori-san, can you please check if this makes sense to you and
> > compare against the graph binding?
> 
> This looks a little bit strange for me.
> Can you show me your DT for it ?

Sure, adding also Sebastian to Cc. Here's what I currently have for droid 4
dts with two codecs on I2S. Please just ignore the GNSS parts there..

The TDM configuration is all done in the cpcap_audio_codec via set_tdm_slot().
The modem voice call codec is a serdev driver :) I'll need some more time to
be able to post patches but it's basically working for voice calls.

Regards,

Tony

8< ---------
diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts 
b/arch/arm/boot/dts/omap4-droid4-xt894.dts
--- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
+++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
@@ -653,6 +653,28 @@
        pinctrl-0 = <&uart1_pins>;
        interrupts-extended = <&wakeupgen GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH
                               &omap4_pmx_core 0xfc>;
+
+       modem {
+               compatible = "motorola,mapphone-mdm6600-serdev";
+               phys = <&fsusb1_phy>;
+               phy-names = "usb";
+
+               mot_mdm6600_audio: audio-codec {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       #sound-dai-cells = <1>;
+
+                       port@0 {
+                               mot_mdm6600_audio_codec0: endpoint {
+                                       remote-endpoint = <&cpu_dai_mdm>;
+                               };
+                       };
+               };
+
+               gnss {
+                       compatible = "motorola,mapphone-mdm6600-gnss";
+               };
+       };
 };
 
 &uart3 {
@@ -746,12 +768,18 @@
        status = "okay";
 
        mcbsp3_port: port {
-               cpu_dai3: endpoint {
+               cpu_dai3: endpoint@0 {
                        dai-format = "dsp_a";
                        frame-master = <&cpcap_audio_codec1>;
                        bitclock-master = <&cpcap_audio_codec1>;
                        remote-endpoint = <&cpcap_audio_codec1>;
                };
+               cpu_dai_mdm: endpoint@1 {
+                       dai-format = "dsp_a";
+                       frame-master = <&cpcap_audio_codec1>;
+                       bitclock-master = <&cpcap_audio_codec1>;
+                       remote-endpoint = <&mot_mdm6600_audio_codec0>;
+               };
        };
 };
 

Reply via email to