Commit-ID: 7e9798871a9186cb831cf693d7ff58085384ccbd Gitweb: https://git.kernel.org/tip/7e9798871a9186cb831cf693d7ff58085384ccbd Author: Bart Van Assche <bvanass...@acm.org> AuthorDate: Thu, 6 Dec 2018 17:11:26 -0800 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue, 11 Dec 2018 14:54:48 +0100
tools/lib/lockdep/tests: Fix shellcheck warnings Use find instead of ls to avoid splitting filenames that contain spaces. Use rm -f instead of if ... then rm ...; fi. This patch addresses all shellcheck complaints about the run_tests.sh shell script. Signed-off-by: Bart Van Assche <bvanass...@acm.org> Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org> Cc: Johannes Berg <johan...@sipsolutions.net> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Sasha Levin <sasha.le...@oracle.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Waiman Long <long...@redhat.com> Cc: johannes.b...@intel.com Cc: t...@kernel.org Link: https://lkml.kernel.org/r/20181207011148.251812-3-bvanass...@acm.org Signed-off-by: Ingo Molnar <mi...@kernel.org> --- tools/lib/lockdep/run_tests.sh | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tools/lib/lockdep/run_tests.sh b/tools/lib/lockdep/run_tests.sh index 9f31f84e7fac..253719ee6377 100755 --- a/tools/lib/lockdep/run_tests.sh +++ b/tools/lib/lockdep/run_tests.sh @@ -7,7 +7,7 @@ if ! make >/dev/null; then exit 1 fi -for i in `ls tests/*.c`; do +find tests -name '*.c' | sort | while read -r i; do testname=$(basename "$i" .c) echo -ne "$testname... " if gcc -o "tests/$testname" -pthread "$i" liblockdep.a -Iinclude -D__USE_LIBLOCKDEP && @@ -16,12 +16,10 @@ for i in `ls tests/*.c`; do else echo "FAILED!" fi - if [ -f "tests/$testname" ]; then - rm tests/$testname - fi + rm -f "tests/$testname" done -for i in `ls tests/*.c`; do +find tests -name '*.c' | sort | while read -r i; do testname=$(basename "$i" .c) echo -ne "(PRELOAD) $testname... " if gcc -o "tests/$testname" -pthread -Iinclude "$i" && @@ -30,7 +28,5 @@ for i in `ls tests/*.c`; do else echo "FAILED!" fi - if [ -f "tests/$testname" ]; then - rm tests/$testname - fi + rm -f "tests/$testname" done
