Gabriel C wrote: > ---------- Forwarded message ---------- > From: Andrew Morton <[EMAIL PROTECTED]> > Date: 25.07.2007 03:36 > Subject: Re: [PATCH] Fix arch/i386/kernel/nmi.c - > 'unknown_nmi_panic_callback' declared 'static' but never defined warning > To: Gabriel C <[EMAIL PROTECTED]> > Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Ingo Molnar < > [EMAIL PROTECTED]>, Andi Kleen <[EMAIL PROTECTED]> > > On Sun, 22 Jul 2007 21:20:38 +0200 Gabriel C <[EMAIL PROTECTED]> > wrote: > >> I get this warning when CONFIG_SYSCTL is not set : >> >> ... >> >> arch/i386/kernel/nmi.c:52: warning: 'unknown_nmi_panic_callback' declared > 'static' but never defined >> ... >> >> Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> >> >> --- >> >> diff --git a/arch/i386/kernel/nmi.c b/arch/i386/kernel/nmi.c >> index 03b7f55..cf11121 100644 >> --- a/arch/i386/kernel/nmi.c >> +++ b/arch/i386/kernel/nmi.c >> @@ -49,8 +49,9 @@ static unsigned int nmi_hz = HZ; >> static DEFINE_PER_CPU(short, wd_enabled); >> >> /* local prototypes */ >> +#ifdef CONFIG_SYSCTL >> static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu); >> - >> +#endif >> static int endflag __initdata = 0; > > guys, please take a closer look at the code which you're changing? We can > obviously move do_nmi_callback() down to above > __trigger_all_cpu_backtrace() and then do away with this declaration > altogether. >
I will try to do it better next time , sorry. Oh and I just realized the fix ( whatever it will be at least ) need be done for arch/x86_64/kernel/nmi.c too. Regards, Gabriel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
