[PATCH 2/2] remoteproc: qcom: q6v5-mss: Add support for parsing fw dt bindings

[Sibi Sankar]

Add support for parsing "qcom,firmware" dt bindings which specifies
the relative paths of mba and modem metadata as a list of strings.
Fallback to the default paths for mba/modem on -EINVAL.

Signed-off-by: Sibi Sankar <si...@codeaurora.org>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 49 +++++++++++++++++++++++++-----
 1 file changed, 41 insertions(+), 8 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c 
b/drivers/remoteproc/qcom_q6v5_mss.c
index 01be7314e176..c4e7700aee0f 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -22,6 +22,7 @@
 #include <linux/kernel.h>
 #include <linux/mfd/syscon.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
@@ -30,6 +31,7 @@
 #include <linux/remoteproc.h>
 #include <linux/reset.h>
 #include <linux/soc/qcom/mdt_loader.h>
+#include <linux/string.h>
 #include <linux/iopoll.h>
 
 #include "remoteproc_internal.h"
@@ -188,6 +190,7 @@ struct q6v5 {
        bool has_alt_reset;
        int mpss_perm;
        int mba_perm;
+       const char *hexagon_mdt_image;
        int version;
 };
 
@@ -860,17 +863,29 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
        phys_addr_t min_addr = PHYS_ADDR_MAX;
        phys_addr_t max_addr = 0;
        bool relocate = false;
-       char seg_name[10];
+       char seg_name[35];
+       char *fw_prefix;
+       char *tmp;
        ssize_t offset;
        size_t size = 0;
        void *ptr;
        int ret;
        int i;
 
-       ret = request_firmware(&fw, "modem.mdt", qproc->dev);
+       fw_prefix = kstrdup(qproc->hexagon_mdt_image, GFP_KERNEL);
+       if (!fw_prefix)
+               return -ENOMEM;
+
+       /* strip out the fw extn */
+       tmp = strrchr(fw_prefix, '.');
+       if (tmp)
+               *tmp = '\0';
+
+       ret = request_firmware(&fw, qproc->hexagon_mdt_image, qproc->dev);
        if (ret < 0) {
-               dev_err(qproc->dev, "unable to load modem.mdt\n");
-               return ret;
+               dev_err(qproc->dev, "unable to load %s\n",
+                       qproc->hexagon_mdt_image);
+               goto release_fw_prefix;
        }
 
        /* Initialize the RMB validator */
@@ -918,7 +933,8 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
                ptr = qproc->mpss_region + offset;
 
                if (phdr->p_filesz) {
-                       snprintf(seg_name, sizeof(seg_name), "modem.b%02d", i);
+                       snprintf(seg_name, sizeof(seg_name), "%s.b%02d",
+                                fw_prefix, i);
                        ret = request_firmware(&seg_fw, seg_name, qproc->dev);
                        if (ret) {
                                dev_err(qproc->dev, "failed to load %s\n", 
seg_name);
@@ -960,6 +976,8 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
 
 release_firmware:
        release_firmware(fw);
+release_fw_prefix:
+       kfree(fw_prefix);
 
        return ret < 0 ? ret : 0;
 }
@@ -1075,9 +1093,10 @@ static int qcom_q6v5_register_dump_segments(struct rproc 
*rproc,
        unsigned long i;
        int ret;
 
-       ret = request_firmware(&fw, "modem.mdt", qproc->dev);
+       ret = request_firmware(&fw, qproc->hexagon_mdt_image, qproc->dev);
        if (ret < 0) {
-               dev_err(qproc->dev, "unable to load modem.mdt\n");
+               dev_err(qproc->dev, "unable to load %s\n",
+                       qproc->hexagon_mdt_image);
                return ret;
        }
 
@@ -1253,6 +1272,8 @@ static int q6v5_probe(struct platform_device *pdev)
        const struct rproc_hexagon_res *desc;
        struct q6v5 *qproc;
        struct rproc *rproc;
+       const char *mba_image;
+       const char *fw_name[2];
        int ret;
 
        desc = of_device_get_match_data(&pdev->dev);
@@ -1262,8 +1283,19 @@ static int q6v5_probe(struct platform_device *pdev)
        if (desc->need_mem_protection && !qcom_scm_is_available())
                return -EPROBE_DEFER;
 
+       ret = of_property_count_strings(pdev->dev.of_node, "qcom,firmware");
+       if (ret != -EINVAL && ret != 2)
+               return -EINVAL;
+
+       ret = of_property_read_string_array(pdev->dev.of_node, "qcom,firmware",
+                                           fw_name, 2);
+       if (ret != -EINVAL && ret != 2)
+               return -EINVAL;
+
+       mba_image = (ret != 2) ? desc->hexagon_mba_image : fw_name[0];
+
        rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops,
-                           desc->hexagon_mba_image, sizeof(*qproc));
+                           mba_image, sizeof(*qproc));
        if (!rproc) {
                dev_err(&pdev->dev, "failed to allocate rproc\n");
                return -ENOMEM;
@@ -1272,6 +1304,7 @@ static int q6v5_probe(struct platform_device *pdev)
        qproc = (struct q6v5 *)rproc->priv;
        qproc->dev = &pdev->dev;
        qproc->rproc = rproc;
+       qproc->hexagon_mdt_image = (ret != 2) ? "modem.mdt" : fw_name[1];
        platform_set_drvdata(pdev, qproc);
 
        ret = q6v5_init_mem(qproc, pdev);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project