Hello, On Thu, 13 Dec 2018 15:33:06 +0100, Miquel Raynal wrote:
> I will re-send a series without this patch. I think it does not hurt to > keep the previous patch adding the pinmux setting in the > Armada-37xx.dtsi file even without using it, so I will drop only this > patch. I tend to disagree here (but perhaps you'll have other arguments to convince me otherwise): the GPIO used for PCIe reset is a completely board-specific thing. You can chose whatever GPIO you want, and each board can be different. Therefore, there is no reason to have such a pinmux configuration at the SoC level (.dtsi), it should be within the particular board that uses that pinmux configuration. This is a rule that we have applied to mvebu platforms in general, and which I believe is fairly common in many DTs. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
