On Wed, Dec 12, 2018 at 12:26:10PM -0800, Eric Biggers wrote: > > As this apparently got merged despite no proper reviews from VFS > > level persons: > > fs-verity has been out for review since August, and Cc'ed to all relevant > mailing lists including linux-fsdevel, linux-ext4, linux-f2fs-devel, > linux-fscrypt, linux-integrity, and linux-kernel. There are tests, > documentation (since v2), and a userspace tool. It's also been presented at > multiple conferences, and has been covered by LWN multiple times. If more > people want to review it, then they should do so; there's nothing stopping > them.
But you did not got a review from someone like Al, Linus, Andrew or me, did you? > Can you elaborate on the actual problems you think the current solution has, > and > exactly what solution you'd prefer instead? Keep in mind that (1) for large > files the Merkle tree can be gigabytes long, (2) Linux doesn't have an API for > file streams, and (3) when fs-verity is combined with fscrypt, it's important > that the hashes be encrypted, so as to not leak information about the > plaintext. Given that you alread use an ioctl as the interface what is the problem of passing this data through the ioctl?
