Thanks a lot for the comments, I'll work on V2 to fix them. I just want to make sure, is there a reason why I shouldn't delete FAT_FIRST_ENT, as Joe Perches commented?
On Fri, Dec 14, 2018 at 5:16 AM OGAWA Hirofumi <hirof...@mail.parknet.co.jp> wrote: > > Joe Perches <j...@perches.com> writes: > > >> > >> -#define FAT_FIRST_ENT(s, x) ((MSDOS_SB(s)->fat_bits == 32 ? > >> 0x0FFFFF00 : \ > >> - MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x)) > >> +#define IS_FAT12(sbi) (sbi->fat_bits == 12) > >> +#define IS_FAT16(sbi) (sbi->fat_bits == 16) > >> +#define IS_FAT32(sbi) (sbi->fat_bits == 32) > > > > sbi should be parenthesized or perhaps better these should be > > static inline bool functions > > Right, rather this is the bug (not hit yet though) that should be fixed. > > Thanks. > -- > OGAWA Hirofumi <hirof...@mail.parknet.co.jp>
