Re: [PATCH] powerpc/prom: fix early DEBUG messages

[Christophe Leroy]

Le 14/12/2018 à 07:22, Michael Ellerman a écrit :
Christophe Leroy <christophe.le...@c-s.fr> writes:

diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index fe758cedb93f..d8e56e03c9c6 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -749,7 +749,11 @@ void __init early_init_devtree(void *params)
        memblock_allow_resize();
        memblock_dump_all();
  
+#ifdef CONFIG_PHYS_64BIT
        DBG("Phys. mem: %llx\n", memblock_phys_mem_size());
+#else
+       DBG("Phys. mem: %x\n", memblock_phys_mem_size());
+#endif

Can we just do:

        DBG("Phys. mem: %llx\n", (unsigned long long)memblock_phys_mem_size());

?


Yes that's obviously better, especially as we don't fix the length of 
the displayed value.
Christophe