Hi Peng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on next-20181218]
[cannot apply to v4.20-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Peng-Hao/misc-pvpanic-return-0-for-empty-body-register-function/20181218-184724
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=6.4.0 make.cross ARCH=nds32 

All errors (new ones prefixed by >>):

   drivers/misc/pvpanic.c: In function 'pvpanic_mmio_exit':
>> drivers/misc/pvpanic.c:256:2: error: implicit declaration of function 
>> 'pvpanic_unregister_pci_driver' [-Werror=implicit-function-declaration]
     pvpanic_unregister_pci_driver();
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   At top level:
   drivers/misc/pvpanic.c:232:13: warning: 'pvpanic_unregister_pci_drvier' 
defined but not used [-Wunused-function]
    static void pvpanic_unregister_pci_drvier(void) {}
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/pvpanic_unregister_pci_driver +256 drivers/misc/pvpanic.c

   249  
   250  static void __exit pvpanic_mmio_exit(void)
   251  {
   252          if (acpi_disabled)
   253                  platform_driver_unregister(&pvpanic_mmio_driver);
   254          else
   255                  pvpanic_unregister_acpi_driver();
 > 256          pvpanic_unregister_pci_driver();
   257  }
   258  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to