Jeff Garzik wrote:
>
> On Tue, 24 Jul 2007, Adrian Bunk wrote:
>> buffered_rmqueue() and prep_new_page() are static functions with only
>> one caller each, and for the normal non-debug case it's a really nice
>> optimization to have them inlined automatically.
>
> I'm not at all sure I agree.
>
> Inlining big functions doesn't actually tend to generally generate any
> better code, so if gcc's logic is "single callsite - always inline", then
> that logic is likely not right.
>
Only up to a threshold, as far as I know.
-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
