On Mon, Dec 17, 2018 at 09:19:07AM +0100, Ulf Hansson wrote: > On Sat, 15 Dec 2018 at 09:45, Yangtao Li <tiny.win...@gmail.com> wrote: > > > > We already have the DEFINE_SHOW_ATTRIBUTE, There is no need to define > > such a macro, so remove define_genpd_open_function and > > define_genpd_debugfs_fops. > > > > Convert them to DEFINE_SHOW_ATTRIBUTE. > > > > Signed-off-by: Yangtao Li <tiny.win...@gmail.com> > > --- > > drivers/base/power/domain.c | 71 +++++++++++++------------------------ > > 1 file changed, 24 insertions(+), 47 deletions(-) > > > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > > index 7f38a92b444a..10a61d6147d0 100644 > > --- a/drivers/base/power/domain.c > > +++ b/drivers/base/power/domain.c > > @@ -2671,7 +2671,7 @@ static int genpd_summary_one(struct seq_file *s, > > return 0; > > } > > > > -static int genpd_summary_show(struct seq_file *s, void *data) > > +static int summary_show(struct seq_file *s, void *data) > > Why rename the function(s)?
Because the macro requires it?
