On Mon, Dec 17, 2018 at 03:31:28PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM8400 > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM8400" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > A trivial function rename from wm8400_module_init to the name > wm8400_driver_init is also done to reduce possible confusion. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Lee Jones <lee.jo...@linaro.org> > Cc: Mark Brown <broo...@opensource.wolfsonmicro.com> > Cc: patc...@opensource.cirrus.com > Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> > Acked-by: Linus Walleij <linus.wall...@linaro.org> > --- > -MODULE_DEVICE_TABLE(i2c, wm8400_i2c_id); > > static struct i2c_driver wm8400_i2c_driver = { > .driver = { > @@ -161,7 +160,7 @@ static struct i2c_driver wm8400_i2c_driver = { > }; > #endif
Do we not want to add suppress_bind_attrs into the i2c_driver struct here? Thanks, Charles