On Sat, 2018-12-22 at 22:53 -0500, Steven Rostedt wrote: > On Sat, 22 Dec 2018 12:03:41 -0600 > Tom Zanussi <zanu...@kernel.org> wrote: > > > Hi Steve, > > > > On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote: > > > On Sat, 22 Dec 2018 11:20:09 -0500 > > > Steven Rostedt <rost...@goodmis.org> wrote: > > > > > > > From: "Steven Rostedt (VMware)" <rost...@goodmis.org> > > > > > > > > The tracing histogram code contains a lot of instances of the > > > > construct: > > > > > > > > strncmp(str, "const", sizeof("const") - 1) > > > > > > > > This can be prone to bugs due to typos or bad cut and paste. > > > > Use > > > > the > > > > str_has_prefix() helper macro instead that removes the need for > > > > having two > > > > copies of the constant string. > > > > > > > > Cc: Tom Zanussi <zanu...@linux.intel.com> > > > > > > I have no idea why I copied your intel email. The linux.intel.com > > > appears to be no longer active. I'm going to rebase to fix this > > > email > > > address. > > > > linux.intel.com is active, but there's no zanussi there, just > > tom.zanussi ;-) > > > > So tom.zanu...@linux.intel.com should work fine. > > BTW, would you give me your ack-by? >
Sure, Acked-by: Tom Zanussi <tom.zanu...@linux.intel.com> Tom > -- Steve >