Hi, On 21/12/2018 07:27, Andrey Smirnov wrote: > Surrounding definitions no longer use explicit shift, so "<< 0" here > serve no purpose. Remove them. No functional change intended. > > Cc: Lorenzo Pieralisi <[email protected]> > Cc: Bjorn Helgaas <[email protected]> > Cc: Fabio Estevam <[email protected]> > Cc: Chris Healy <[email protected]> > Cc: Lucas Stach <[email protected]> > Cc: Leonard Crestez <[email protected]> > Cc: "A.s. Dong" <[email protected]> > Cc: Richard Zhu <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Andrey Smirnov <[email protected]> > --- > drivers/pci/controller/dwc/pcie-designware.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h > b/drivers/pci/controller/dwc/pcie-designware.h > index 0de653284fca..636689fd4ee7 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -63,14 +63,14 @@ > #define PCIE_ATU_VIEWPORT 0x900 > #define PCIE_ATU_REGION_INBOUND BIT(31) > #define PCIE_ATU_REGION_OUTBOUND 0 > -#define PCIE_ATU_REGION_INDEX2 (0x2 << 0) > -#define PCIE_ATU_REGION_INDEX1 (0x1 << 0) > -#define PCIE_ATU_REGION_INDEX0 (0x0 << 0) > +#define PCIE_ATU_REGION_INDEX2 0x2 > +#define PCIE_ATU_REGION_INDEX1 0x1 > +#define PCIE_ATU_REGION_INDEX0 0x0 > #define PCIE_ATU_CR1 0x904 > -#define PCIE_ATU_TYPE_MEM (0x0 << 0) > -#define PCIE_ATU_TYPE_IO (0x2 << 0) > -#define PCIE_ATU_TYPE_CFG0 (0x4 << 0) > -#define PCIE_ATU_TYPE_CFG1 (0x5 << 0) > +#define PCIE_ATU_TYPE_MEM 0x0 > +#define PCIE_ATU_TYPE_IO 0x2 > +#define PCIE_ATU_TYPE_CFG0 0x4 > +#define PCIE_ATU_TYPE_CFG1 0x5 > #define PCIE_ATU_CR2 0x908 > #define PCIE_ATU_ENABLE BIT(31) > #define PCIE_ATU_BAR_MODE_ENABLE BIT(30) >
Agree. Acked-off-by: Gustavo Pimentel <[email protected]> Thanks.
