In rv8803_handle_irq, rv8803_write_reg can return a failed return
value when attempting to write to the bus. The fix checks the output
and throws a dev_warn notifying of the failure.

Signed-off-by: Aditya Pakki <pakki...@umn.edu>
---
 drivers/rtc/rtc-rv8803.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c
index 450a0b831a2d..5a19d5ecbf57 100644
--- a/drivers/rtc/rtc-rv8803.c
+++ b/drivers/rtc/rtc-rv8803.c
@@ -180,8 +180,13 @@ static irqreturn_t rv8803_handle_irq(int irq, void *dev_id)
 
        if (events) {
                rtc_update_irq(rv8803->rtc, 1, events);
-               rv8803_write_reg(client, RV8803_FLAG, flags);
-               rv8803_write_reg(rv8803->client, RV8803_CTRL, rv8803->ctrl);
+               if (rv8803_write_reg(client, RV8803_FLAG, flags))
+                       dev_warn(&client->dev, "Failed to write RV8803 reg.\n");
+
+               if (rv8803_write_reg(rv8803->client, RV8803_CTRL,
+                                       rv8803->ctrl))
+                       dev_warn(&rv8803->client->dev,
+                               "Failed to write RV8803_CTRL reg.\n");
        }
 
        mutex_unlock(&rv8803->flags_lock);
-- 
2.17.1

Reply via email to