Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: YueHaibing <yuehaib...@huawei.com>
---
 kernel/panic.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index d10c340..d3d8a44 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -615,16 +615,14 @@ static int clear_warn_once_set(void *data, u64 val)
        return 0;
 }
 
-DEFINE_SIMPLE_ATTRIBUTE(clear_warn_once_fops,
-                       NULL,
-                       clear_warn_once_set,
-                       "%lld\n");
+DEFINE_DEBUGFS_ATTRIBUTE(clear_warn_once_fops, NULL, clear_warn_once_set,
+                        "%lld\n");
 
 static __init int register_warn_debugfs(void)
 {
        /* Don't care about failure */
-       debugfs_create_file("clear_warn_once", 0200, NULL,
-                           NULL, &clear_warn_once_fops);
+       debugfs_create_file_unsafe("clear_warn_once", 0200, NULL, NULL,
+                                  &clear_warn_once_fops);
        return 0;
 }
 





Reply via email to